Skip to content

Revert "use Pytree as base type in nnx_wrappers" #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gulsumgudukbay merged 3 commits into from
Sep 23, 2025
+2 −2
Merged

Revert "use Pytree as base type in nnx_wrappers" #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1b7b98
Revert "use Pytree as base type in nnx_wrappers"
gulsumgudukbay Sep 23, 2025
70c715b
Added a TODO to convert the import
gulsumgudukbay Sep 23, 2025
af61b46
Update nnx_wrappers.py
gulsumgudukbay Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MaxText/layers/nnx_wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from flax.nnx import variablelib
from flax.nnx.bridge import module as bdg_module
from flax.nnx.module import Module
from flax.nnx import Pytree
from flax.nnx import Object # TODO(gulsumgudukbay) convert this import to from flax.nnx import Pytree after ROCm/jax supports flax >= 0.11.0
from flax.nnx.rnglib import Rngs
import jax
from jax import tree_util as jtu
Expand Down Expand Up @@ -140,7 +140,7 @@ def nnx_attrs_to_linen_vars(nnx_attrs: dict) -> dict:

def _set_initializing(module: Module, initializing: bool):
for _, value in graph.iter_graph(module):
if isinstance(value, Pytree):
if isinstance(value, Object):
value._object__state._initializing = initializing # pylint: disable=protected-access


Expand Down
Loading