[HeterogeneousDWARF] Stop emitting DW_AT_address_class on pointer types #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute isn't fully supported GDB and it's usage was leading to some errors. Fixes SWDEV-565489
lancesix
reviewed
Nov 11, 2025
lancesix
left a comment
lancesix
left a comment
There was a problem hiding this comment.
Too bad GitHub does not have +1.
I picked that patch on top of amd-staging, and it seems to be all good as far as I can see. It fixes the regressions seen, and provide the DW_AT_LLVM_address_space attribute when needed while dropping the DW_AT_address_class which was causing issues.
Thanks!
slinder1
approved these changes
Nov 11, 2025
Author
|
@kzhuravl I think that the readthedocs builds should be disabled for amd-debug. They're failing because they're trying to read some configuration files in the llvm-project/amd directory, but that doesn't exist for amd-debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute isn't fully supported GDB and it's usage was leading to some errors. Fixes SWDEV-565489