SWDEV-465214 - Change carveout tests; value shall be ignored on AMD #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Unit_hipFuncSetAttribute_Positive_PreferredSharedMemoryCarveout_Not_Supported and change Unit_hipFuncSetAttribute_Positive_PreferredSharedMemoryCarveout so it expects the value to be ignored if withing the allowed range Change-Id: I6f52788667082075dd46605dfa84d460c3acac0d
Contributor
Author
|
Imported to ROCm/rocm-systems |
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR recreates Gerrit's patch: https://gerrit-git.amd.com/c/compute/ec/hip-tests/+/1193797
Pending conversation from that patch:
Maneesh Gupta
I guess another way to implement this test would be to have the REQUIRE line only in the nv case, while in the amd case we would do the set, but not the REQUIRE.
Gerardo Hernandez
If we do the setAttribute(), but not the REQUIRE() on AMD, as you say, it would not demonstrate that the value being passed to hipFuncSetAttribute() is ignored on AMD. i.e. in the test I am demonstrating that the value stays the same; hence proving it is ignored.
Is that not the right thing to do?
@mangupta_amdeng