Skip to content

SWDEV-481433 - enable atomic tests on windows #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rocm-devops wants to merge 1 commit into from
Closed

SWDEV-481433 - enable atomic tests on windows #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion catch/hipTestMain/config/config_amd_linux
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,6 @@
"Unit_Device___float2half_rd_SmallVals_Sanity_Positive",
"Unit_Device___float2half_ru_SmallVals_Sanity_Positive",
"Unit_Device___float2half_rz_SmallVals_Sanity_Positive",
"Unit_safeAtomicMin_Positive_SameAddress - float",
"=== SWDEV-454220 : Below test hanged in stress test on 22/03/24 ===",
"Unit_hipExtLaunchKernel_Positive_Basic",
"=== Temporarily disable the test that failed in mi300 ===",
Expand Down
1 change: 0 additions & 1 deletion catch/hipTestMain/config/config_amd_windows
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,6 @@
"Unit_hipMemset2DAsync_capturehipMemset2DAsync",
"Unit_hipOccupancyMaxPotBlkSizeVariableSMemWithFlags_Functional",
"Unit_hipDynamicShared",
"Unit___hip_atomic_fetch_min_Positive_Workgroup_Scattered_Addresses - double",
"Unit_atomicExch_Positive - int",
"Unit_atomicExch_Positive - unsigned int",
"Unit_atomicExch_Positive - unsigned long",
Expand Down
2 changes: 1 addition & 1 deletion catch/include/cmd_options.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ THE SOFTWARE.
#include <limits>

struct CmdOptions {
int iterations = 10;
int iterations = 2;
int warmups = 100;
int cg_extended_run = 5;
int cg_iterations = 5;
Expand Down
2 changes: 0 additions & 2 deletions catch/unit/atomics/arithmetic_common.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,13 +508,11 @@ void SingleDeviceSingleKernelTest(const unsigned int width, const unsigned int p
}
}
}
#ifdef __linux__
SECTION("Shared memory") {
params.blocks = dim3(1);
params.alloc_type = LinearAllocs::hipMalloc;
TestCore<TestType, operation, true, memory_scope>(params);
}
#endif
}

// Configures and creates the TestCore for a single device, and multiple kernel launches
Expand Down
3 changes: 1 addition & 2 deletions catch/unit/atomics/bitwise_common.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,13 +342,12 @@ void SingleDeviceSingleKernelTest(const unsigned int width, const unsigned int p
}
}
}
#ifdef __linux__

SECTION("Shared memory") {
params.blocks = dim3(1);
params.alloc_type = LinearAllocs::hipMalloc;
TestCore<TestType, operation, true>(params);
}
#endif
}

template <typename TestType, AtomicOperation operation>
Expand Down
2 changes: 0 additions & 2 deletions catch/unit/atomics/min_max_common.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,11 @@ void SingleDeviceSingleKernelTest(const unsigned int width, const unsigned int p
}
}
}
#ifdef __linux__
SECTION("Shared memory") {
params.blocks = dim3(1);
params.alloc_type = LinearAllocs::hipMalloc;
TestCore<TestType, operation, true>(params);
}
#endif
}

template <typename TestType, AtomicOperation operation>
Expand Down