Skip to content

SWDEV-450052 - Fixes for negative cases of hipExtLaunchMultiKernelMul… #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rocm-devops wants to merge 1 commit into from
Closed

SWDEV-450052 - Fixes for negative cases of hipExtLaunchMultiKernelMul… #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions catch/unit/executionControl/hipExtLaunchMultiKernelMultiDevice.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,32 +90,6 @@ TEST_CASE("Unit_hipExtLaunchMultiKernelMultiDevice_Negative_Parameters") {
hipErrorInvalidValue);
}

if (device_count > 1) {
SECTION("launchParamsList.func doesn't match across all devices") {
params_list[1].func = reinterpret_cast<void*>(kernel2);
HIP_CHECK_ERROR(hipExtLaunchMultiKernelMultiDevice(params_list.data(), device_count, 0u),
hipErrorInvalidValue);
}

SECTION("launchParamsList.gridDim doesn't match across all kernels") {
params_list[1].gridDim = dim3{2, 2, 2};
HIP_CHECK_ERROR(hipExtLaunchMultiKernelMultiDevice(params_list.data(), device_count, 0u),
hipErrorInvalidValue);
}

SECTION("launchParamsList.blockDim doesn't match across all kernels") {
params_list[1].blockDim = dim3{2, 2, 2};
HIP_CHECK_ERROR(hipExtLaunchMultiKernelMultiDevice(params_list.data(), device_count, 0u),
hipErrorInvalidValue);
}

SECTION("launchParamsList.sharedMem doesn't match across all kernels") {
params_list[1].sharedMem = 1024;
HIP_CHECK_ERROR(hipExtLaunchMultiKernelMultiDevice(params_list.data(), device_count, 0u),
hipErrorInvalidValue);
}
}

for (const auto params : params_list) {
HIP_CHECK(hipStreamDestroy(params.stream));
}
Expand All @@ -136,7 +110,7 @@ TEST_CASE("Unit_hipExtLaunchMultiKernelMultiDevice_Negative_MultiKernelSameDevic
}

HIP_CHECK_ERROR(hipExtLaunchMultiKernelMultiDevice(params_list.data(), 2, 0u),
hipErrorInvalidValue);
hipErrorInvalidDevice);

for (const auto params : params_list) {
HIP_CHECK(hipStreamDestroy(params.stream));
Expand Down
Loading