SWDEV-519340 - Enable and fix hipModuleLoad test #587
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!verify |
2 similar comments
Contributor
Author
|
!verify |
Contributor
Author
|
!verify |
Contributor
Author
|
@rorakesh_amdeng : Has stress testing passed for this PR? |
12 tasks
Contributor
Author
|
Imported to ROCm/rocm-systems |
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
SWDEV-519340
What type of PR is this? (check all applicable)
What were the changes?
I refactored the CMake file for module unit tests and fixed the unit tests so that they now pass on both AMD and NV platforms.
hipExtModuleLaunchKernel.cc is formatted and the only real change is changing mg.module() to GetModule()
Why are these changes needed?
ModuleLoad tests were disabled and failing; hence, the change was made to enable it.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks