SWDEV-505930 - Avoid static initialization of ModuleGuard #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent calling catch2 macros from outside catch2 TEST_CASE that can lead to undefined bahavior. This change also disables hipGetProcAddress tests that are not supported on static build.
12 tasks
Contributor
Author
|
Imported to ROCm/rocm-systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
Fixes SWDEV-505930
What type of PR is this? (check all applicable)
What were the changes?
Avoid static initialization of ModuleGuard. This change also disables hipGetProcAddress tests that are not supported on static build.
Why are these changes needed?
This is to prevent calling catch2 macros from outside catch2 TEST_CASE that can lead to undefined behavior.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks