Log every command before being executed and after being executed.#93
Merged
Conversation
cijohnson
reviewed
Mar 3, 2026
| # Log command execution | ||
| if self.log: | ||
| if timeout is not None: | ||
| self.log.info(f"Executing command on {len(self.reachable_hosts)} host(s) [timeout={timeout}s]: {cmd}") |
Collaborator
There was a problem hiding this comment.
Can we make it debug level instead of info level?
cijohnson
requested changes
Mar 3, 2026
cijohnson
left a comment
cijohnson
left a comment
Collaborator
There was a problem hiding this comment.
Can we log these at debug level? else in a 1000 node setup we will be adding about 2000 lines for each command executed.
Also UT failed, please refer https://github.com/ROCm/cvs/pull/93/checks for logs
make test, will help identify ut/format/lint issue early before CI
This exactly informs the user as to whats happening when commands are being run
cijohnson
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exactly informs the user as to whats happening when commands are being run
Motivation
want to know what command is being run on each host
Technical Details
add a log
Test Plan
run cvs command to start a test.
Test Result
It prints the exact command run on each server.
Submission Checklist