Skip to content

fix(megatron_training_lib): correct training-log parsing and drop sudo from libbnxt cp #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atnair-amd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(megatron_training_lib): correct training-log parsing and drop sudo from libbnxt cp #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c827d
fix(megatron_training_lib): correct training-log parsing and drop sud…
atnair-amd May 17, 2026
f91e6c8
Tolerate variable spacing around '/' in iteration patterns
atnair-amd May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cvs/lib/megatron_training_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@
}

TRAINING_PROGRESS_PATTERNS = [
r'throughput per GPU(?:\s*\([^)]*\))?\s*:|tokens\/GPU\/s\s+[0-9]+',
r'throughput per GPU:|tokens\/GPU\/s\s+[0-9]+',
r'iteration\s+(\d+)\s*/\s*\1\s*\|',
]

TRAINING_NAN_PATTERNS = [
Expand Down Expand Up @@ -384,7 +383,7 @@ def exec_nic_setup_scripts(
# override the gid_index to 3 for broadcom
self.nccl_ib_gid_index = 3
out_dict = self.phdl.exec(
f'docker exec {self.container_name} /bin/bash -c "sudo \
f'docker exec {self.container_name} /bin/bash -c " \
cp /usr/lib/x86_64-linux-gnu/libibverbs/libbnxt_re-rdmav34.so.host \
/usr/lib/x86_64-linux-gnu/libibverbs/libbnxt_re-rdmav34.so; \
sleep 2;ibv_devinfo;sleep 2;"'
Expand Down Expand Up @@ -581,10 +580,17 @@ def get_training_results_dict(
- re is imported in the module scope.
"""

# Read the training log output from the "last" node (assumed authoritative)
# Read the training log output from the "last" node (assumed authoritative).
# Filter to megatron iteration lines BEFORE tailing: post-training cleanup
# (aiter import spam, validation eval, NCCL teardown warnings) can otherwise
# push iteration lines out of a `tail -15` window, leaving the parser with
# nothing to match and silently emitting an empty results_dict.
last_node = self.host_list[len(self.host_list) - 1]
last_node_num = len(self.host_list) - 1
out_dict = self.phdl.exec(f'cat {self.log_dir}/megatron-logs/out-node{last_node_num}/training.log | tail -15')
out_dict = self.phdl.exec(
f"grep -E 'iteration[[:space:]]+[0-9]+[[:space:]]*/[[:space:]]*[0-9]+[[:space:]]*\\|' "
f"{self.log_dir}/megatron-logs/out-node{last_node_num}/training.log | tail -15"
)

# Select the log content from the last node
output = out_dict[last_node]
Expand Down
Loading