Implement grouped gemm tile loop for RDNA4 #3304
Open
+3,067
−1,223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for grouped gemm Tile Loop instances on RDNA4. This PR contains:
DeviceGroupedGemmMultipleD_Wmma_CShuffle_TileLoop_V3)profile_grouped_gemm_tile_loop_generic_implwhich supports all variants.profile_grouped_gemm_tile_loop_implandprofile_grouped_gemm_tile_loop_multiply_generic_impl. The interfaces are kept for compatibility and redirect to the new generic implementation.MultiplyAddoperator where the calculation was performed in data type of the E tensor, instead of the accumulator data type, causing precision issues.tuple_element_or_thelper to the general tuple header. This allows retrieving a type element from the tuple, or default to a specific type if the index is out of rangeNote that this PR is dependent on this: #3303
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered