Generate GPU Component runtime summary and rank-channel variance #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyazdanb
reviewed
Dec 5, 2025
Collaborator
There was a problem hiding this comment.
rebase it to the main. The updated versions of these files are in the main. Put your changes on top of them.
oyazdanb
reviewed
Dec 5, 2025
Collaborator
There was a problem hiding this comment.
rebase your branch. This file has a new version that is on the main. Put your changes on top of that.
oyazdanb
reviewed
Dec 5, 2025
|
|
||
| col_type_name = 0 | ||
| col_256_time = 3 | ||
| col_512_time = 5 |
oyazdanb
reviewed
Dec 5, 2025
| if i==0 : | ||
| continue | ||
| all_results[row[col_type_name]]['256'][c].append(float(row[col_256_time])) | ||
| all_results[row[col_type_name]]['512'][c].append(float(row[col_512_time])) |
Collaborator
There was a problem hiding this comment.
remove the hardcoded values.
oyazdanb
reviewed
Dec 5, 2025
| type=Path, | ||
| default=Path("/home/oyazdanb/aorta/experiments/sweep_20251121_155219/tracelens_analysis"), | ||
| help='Base path to tracelens_analysis directory (default: %(default)s)' | ||
| ) |
Collaborator
There was a problem hiding this comment.
no personal path. change the path to a generic one. Also, remove the default path and force the user to pass it.
|
|
||
| col_type_name = 0 | ||
| col_256_time = 3 | ||
| col_512_time = 5 |
| '--base-path', | ||
| type=Path, | ||
| default=Path("/home/oyazdanb/aorta/experiments/sweep_20251121_155219/tracelens_analysis"), | ||
| help='Base path to tracelens_analysis directory (default: %(default)s)' |
| plot_mean_result(output_dir, type_list, mean_results, threads=thread_configs) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() |
Collaborator
There was a problem hiding this comment.
this script has similarities with generate_comparison_report_channel_variance.py. Consolidate them. Also update README with the scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates :