Skip to content

Conversation

@prosenjitdhole
Copy link
Collaborator

Orignal PR : #23 : Split across mutiple prs
subpr : 5
Files :

  • scripts/tracelens_single_config/create_final_report.py
  • scripts/tracelens_single_config/run_full_analysis.py

@@ -0,0 +1,387 @@
#!/usr/bin/env python3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script looks like it is essentially just a series of run commands. Would it be better as a bash script?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is kept as python as going forward we can :

  1. Keep a single top level full_analysis script for all the flows
  2. Add more functionality (which could be difficult in bash)
  3. Add more design complexity.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what further functionality (that would be difficult in bash) or design complexity are we looking to add?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We plan to have a container injection on this run_full_analysis, where the steps are predefined (using a contractor) but the filler will come from an implementation specific to a flow.

Also, in a general guideline, we are converting our existing scripts to python as well for aorta (like @oyazdanb is converting all our bash files to python).

@prosenjitdhole prosenjitdhole merged commit 60b9d47 into main Dec 9, 2025
5 checks passed
@prosenjitdhole prosenjitdhole deleted the tracelense_single_config_5 branch December 9, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants