Generate merged report and plots for rccl runs #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyazdanb
reviewed
Dec 5, 2025
| return None | ||
|
|
||
|
|
||
| def create_final_html(plot_file_path, output_path): |
Collaborator
There was a problem hiding this comment.
Could we extend/modify one of the existing HTML report generators instead of creating a new one? We already have:
This would help reduce code duplication and make maintenance easier. If there are specific features needed that aren't in those scripts, perhaps we could enhance one of them instead?
oyazdanb
force-pushed
the
users/oyazdanb/rccl_test
branch
from
f45a06d to
4e348e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates the final html report.
Need to fill in :