hipblaslt Fallback hotfix#652
Merged
Merged
Conversation
alextmagro
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
wenchenvincent
approved these changes
Jun 26, 2026
ipanfilo
reviewed
Jun 27, 2026
ipanfilo
left a comment
ipanfilo
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just minor note. it is already approved
| static_cast<int>(outputPreGelu->data.dtype), | ||
| workspace, workspaceSize, s); | ||
| } | ||
| if (!use_hipkittens || !hipkittens_gemm_complete) { |
Collaborator
There was a problem hiding this comment.
nit: no need to check use_hipkittens - hipkittens_gemm_complete can only be True if use_hipkittens is True. Only use_hipkittens can be sufficient (nohipkittens_gemm_complete) , if assign it at line 2004
Contributor
Author
There was a problem hiding this comment.
I have simplified the check as you mentioned.
ipanfilo
reviewed
Jun 29, 2026
| #ifdef USE_HIPKITTENS_GEMM | ||
|
|
||
| bool use_hipkittens = false; | ||
| bool use_hipkittens = false, hipkittens_gemm_complete = false; |
Contributor
Author
There was a problem hiding this comment.
Sorry, missed that. Should be fixed now.
ipanfilo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where HipKittens does not fall back to hipBLASlt for unaligned mxfp8 GEMMs.