-
Notifications
You must be signed in to change notification settings - Fork 46
feat(vllm): add Gemma 4 models, image, and ROCm serving recipes #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coketaste
wants to merge
8
commits into
ROCm:develop
Choose a base branch
from
coketaste:coketaste/gemma4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e188f6
feat(vllm): add Gemma 4 models, image, and ROCm serving recipes
coketaste 912aebc
Merge branch 'ROCm:develop' into coketaste/gemma4
coketaste b4de892
chore(vllm): bump base image to vllm-openai-rocm v0.20.0, pin transfo…
coketaste 77f0161
feat(vllm): consolidate Gemma 4 models into standard pyt_vllm stack
coketaste 76bc276
docs(vllm): update README — Gemma 4 now uses standard pyt_vllm image
coketaste b455096
fix(vllm): apply shlex.quote to all non-bool extra_args values (was p…
coketaste 11d6bd8
fix(vllm): address PR review feedback and enable full concurrency
coketaste cac3f03
fix(vllm): address Copilot review — ENTRYPOINT, bool flags, testable …
coketaste File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # CONTEXT {'gpu_vendor': 'AMD', 'guest_os': 'UBUNTU'} | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ################################################################################# | ||
| # Gemma 4 requires a vLLM build with Gemma4 support; see vLLM recipes (Google/Gemma4.md). | ||
| ARG BASE_DOCKER=vllm/vllm-openai-rocm:gemma4 | ||
| FROM $BASE_DOCKER | ||
|
|
||
| USER root | ||
| ENV WORKSPACE_DIR=/workspace | ||
| RUN mkdir -p $WORKSPACE_DIR | ||
| WORKDIR $WORKSPACE_DIR | ||
|
|
||
| RUN pip3 install --no-cache-dir "transformers==5.5.0" | ||
|
|
||
| # record configuration for posterity | ||
| RUN pip3 list | ||
|
|
||
| # Specify entrypoint to override upstream | ||
| ENTRYPOINT [""] | ||
|
coketaste marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.