Skip to content

Conversation

@kirthana14m
Copy link
Collaborator

No description provided.

@kirthana14m kirthana14m self-assigned this Jan 13, 2026
@kirthana14m kirthana14m added the infrastructural related to the Repo infrastructure label Jan 13, 2026
@kirthana14m kirthana14m requested a review from searlmc1 as a code owner January 13, 2026 07:38
@kirthana14m kirthana14m requested a review from emankov as a code owner January 13, 2026 07:38
@emankov emankov added the test Testing is only affected label Jan 13, 2026
@emankov emankov changed the title [HIPIFY][Infra] Enable Linux rock ci psdb for staging [HIPIFY][Infra] Enable Linux Rock CI PSDB for amd-staging Jan 13, 2026
@emankov emankov changed the title [HIPIFY][Infra] Enable Linux Rock CI PSDB for amd-staging [HIPIFY][test][Infra] Enable Linux Rock CI PSDB for amd-staging Jan 13, 2026
@emankov emankov changed the title [HIPIFY][test][Infra] Enable Linux Rock CI PSDB for amd-staging [HIPIFY][test][infra] Enable Linux Rock CI PSDB for amd-staging Jan 13, 2026
Copy link
Collaborator

@skganesan008 skganesan008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is too long. I am still not sure why we need to add the repository name in the prefix Evgeny. Both [HIPIFY] and [test] seems to be not needed if the intention is to differentiate between infra and non infra changes.

@emankov
Copy link
Collaborator

emankov commented Jan 14, 2026

The commit message is too long. I am still not sure why we need to add the repository name in the prefix Evgeny. Both [HIPIFY] and [test] seems to be not needed if the intention is to differentiate between infra and non infra changes.

I believe I already answered in the previous PR #2271, which has been submitted to amd-mainline with all the suffixes.
HIPIFY lived in HIP, then it was split into its own repo, and now it is going to be upstreamed to LLVM. The prefixes must not be removed.

@skganesan008
Copy link
Collaborator

The commit message is too long. I am still not sure why we need to add the repository name in the prefix Evgeny. Both [HIPIFY] and [test] seems to be not needed if the intention is to differentiate between infra and non infra changes.

I believe I already answered in the previous PR #2271, which has been submitted to amd-mainline with all the suffixes. HIPIFY lived in HIP, then it was split into its own repo, and now it is going to be upstreamed to LLVM. The prefixes must not be removed.

Thank you; my query/comment was about commit message getting too long. we may not be able to give a precise description of the patch at the title level sometimes with this requirement. git commit title length recommendation seems to be around 50 chars for the title and 72 chars for the description. It is not strictly enforced, but a standard promoted by github. This is just something to keep in mind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructural related to the Repo infrastructure test Testing is only affected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants