-
Notifications
You must be signed in to change notification settings - Fork 102
[HIPIFY][test][infra] Enable Linux Rock CI PSDB for amd-staging
#2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: amd-staging
Are you sure you want to change the base?
[HIPIFY][test][infra] Enable Linux Rock CI PSDB for amd-staging
#2294
Conversation
Linux Rock CI PSDB for amd-staging
Linux Rock CI PSDB for amd-stagingLinux Rock CI PSDB for amd-staging
Linux Rock CI PSDB for amd-stagingLinux Rock CI PSDB for amd-staging
skganesan008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message is too long. I am still not sure why we need to add the repository name in the prefix Evgeny. Both [HIPIFY] and [test] seems to be not needed if the intention is to differentiate between infra and non infra changes.
I believe I already answered in the previous PR #2271, which has been submitted to |
Thank you; my query/comment was about commit message getting too long. we may not be able to give a precise description of the patch at the title level sometimes with this requirement. git commit title length recommendation seems to be around 50 chars for the title and 72 chars for the description. It is not strictly enforced, but a standard promoted by github. This is just something to keep in mind... |
No description provided.