[atom CI/Nightly/Benchmark] Add MiniMax-M3 and Eagle#1356
Merged
Conversation
zejunchen-zejun
commented
Jun 25, 2026
Collaborator
into atom infra Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
valarLip
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ATOM’s CI benchmark/accuracy configuration to introduce MiniMax-M3 (MXFP8/MXFP4) and an EAGLE3 speculative decoding variant, wiring them into the nightly/manual benchmark catalog and adding GSM8K accuracy baselines/thresholds for M3 MXFP4 (and its Eagle3 mode).
Changes:
- Replaced MiniMax-M2.7 benchmark dispatch toggles with new
m3-mxfp8/m3-mxfp4toggles in the benchmark workflow. - Updated the benchmark model catalog to add MiniMax-M3 MXFP8/MXFP4 entries, each with an EAGLE3 variant.
- Added accuracy entries (baseline/threshold + custom lm_eval command) for MiniMax-M3 MXFP4 and MiniMax-M3 MXFP4 Eagle3.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/atom-benchmark.yaml | Updates workflow_dispatch model toggles to select the new M3 benchmark prefixes. |
| .github/benchmark/models.json | Replaces MiniMax-M2.7 entries with MiniMax-M3 MXFP8/MXFP4 and adds EAGLE3 benchmark variants. |
| .github/benchmark/models_accuracy.json | Adds GSM8K accuracy baselines/thresholds and commands for M3 MXFP4 (+ Eagle3). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "label": "EAGLE3", | ||
| "suffix": "-eagle3", | ||
| "extra_args": "--max-num-seqs 256 --method eagle3 --draft-model Inferact/MiniMax-M3-EAGLE3 --num-speculative-tokens 3", |
| { | ||
| "label": "EAGLE3", | ||
| "suffix": "-eagle3", | ||
| "extra_args": "--max-num-seqs 256 --method eagle3 --draft-model Inferact/MiniMax-M3-EAGLE3 --num-speculative-tokens 3", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.