Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command flow #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Command flow #37

wants to merge 2 commits into from

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Dec 17, 2024

In support of RMI-PACTA/workflow.pacta.webapp#33

Adds a (mandatory) commands object to JSON schema (with report object as a boolean value), which is used in workflow.pacta.webapp to control whether the interactive report is generated or not.

Copy link

Docker build status

commit_time git_sha image
2024-12-17T14:46:09Z d015a69 ghcr.io/rmi-pacta/workflow.pacta.report:pr-37

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (aab9142) to head (d015a69).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #37   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        501     501           
=====================================
  Misses       501     501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Report Links

commit_time git_sha config report summary image
2024-12-17T14:46:09Z d015a69 default_2022Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-37
2024-12-17T14:46:09Z d015a69 default_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-37
2024-12-17T14:46:09Z d015a69 full_params_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-37

@AlexAxthelm AlexAxthelm requested a review from jdhoffa December 17, 2024 14:56
@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 17, 2024 15:02
@jdhoffa
Copy link
Member

jdhoffa commented Dec 17, 2024

Approved in principle, pending confirmation that it makes sense to implement this 😊

@jdhoffa
Copy link
Member

jdhoffa commented Dec 20, 2024

I will review this in January 😊
@AlexAxthelm please remind me in case I forget!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants