Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose green_or_brown dataset as argument #428

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Expose green_or_brown dataset as argument #428

merged 4 commits into from
Jan 27, 2023

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 27, 2023

Closes #426

@jdhoffa jdhoffa requested a review from jacobvjk January 27, 2023 08:38
jacobvjk
jacobvjk reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdhoffa I think the function documentation of target_market_share() also needs an update?

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 27, 2023

Ah yeah, sorry i did that locally but didn't seem to commit it oops

@jacobvjk jacobvjk self-requested a review January 27, 2023 13:11
@jdhoffa jdhoffa merged commit 3efa2bc into main Jan 27, 2023
@jdhoffa jdhoffa deleted the 426-expose_green_or_brown branch January 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@jacobvjk jacobvjk jacobvjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: surface high/low carbon technologies
3 participants
@jdhoffa @cjyetman @jacobvjk