Fix nat gas cap handling #29

jacobvjk · 2023-03-20T16:57:04Z

This PR:

replaces the natural gas cap with allowance band for the simpler 2 sided natural gas cap to reflect the recent IEA and JRC scenario pathways
the 2 sided cap for the bridge technology (currently only natural gas power) is split out into an optional function apply_bridge_technology_cap() to clean up calculate_company_tech_deviation() significantly
function argument bridge_tech gets explicitly allowed values and rlang::arg_match treatment for more robustness. the corresponding input argument checks are cleaned up
adds handling for the JRC scenario for SDA sectors, as the name gets slightly chopped up when running r2dii.analysis (related to separate_metric_from_name() splits up some scenario names wrong r2dii.analysis#425)

MonikaFu

LGTM

jacobvjk added 10 commits March 17, 2023 11:38

join year columns correctly

b34f8f8

temp fix for geco scenario name

1e67f26

Merge branch 'main' into bug_nat_gas_cap

7c58b2e

structure workflow

2ce5deb

simple 2 sided nat gas cap

e65a38f

workflow back to standard setting

d445411

Merge branch 'main' into bug_nat_gas_cap

8e241c9

rm dead code

c522667

split bridge tech handling into sep function

bdc003e

update docs and input checks

0e15608

jacobvjk changed the title ~~Bug nat gas cap~~ Fix nat gas cap handling Mar 21, 2023

jacobvjk marked this pull request as ready for review March 21, 2023 10:20

jacobvjk requested review from AlexAxthelm and MonikaFu March 21, 2023 10:21

MonikaFu approved these changes Mar 21, 2023

View reviewed changes

jacobvjk merged commit 5ea3430 into main Mar 21, 2023

jacobvjk deleted the bug_nat_gas_cap branch March 21, 2023 10:30

Provide feedback