Feat: Make pies resizeable and remove titles #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhoffa
reviewed
Nov 6, 2024
src/js/pie_exploded.js
Outdated
| // Plot labels | ||
| let numbers_long = { M: ' million', G: ' billion', T: ' trillion' }; | ||
| let unit = 'USD'; // TODO: make a parameter | ||
| let comment = 'Total: '; |
There was a problem hiding this comment.
Suggested change
| let comment = 'Total: '; | |
| let comment = 'Exposure of Assets to PACTA Sectors: '; |
I would rather not merge the "Total" caption in, since we know that is confusing.
Let's use this for now as it is at least accurate, and then Nayra can validate all these things after a more in-depth review.
Relates to #51
There was a problem hiding this comment.
I expect that the plot will have a descriptive title in which case I am not sure if 'Total' is not enough. Also, in case of emissions I don't think we can call it 'exposure'?
jdhoffa
requested changes
Nov 6, 2024
|
@jdhoffa I extended the annotation and made it variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
In this PR I:
NOTE: the layout of the portfolio view needs to change in another PR for the change to be fully visible and to look good.