Benchmark data-driven #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we expect "bank" as a selectable Benchmark here? 
|
|
@jdhoffa it's just an artifact of the test data we're using. In GENERAL we don't. |
|
If we would be running the dahsboard on peer data then yes, 'bank' could be a benchmark. It should be called 'Banks' then I'd say or 'Banks peer group' but I think it should be adjusted in the data and not in the dashboard code. |
|
Makes sense! I was just nervous that it was the actual portfolio value, which we of course don't want to appear as a benchmark, but that seems to not be the case |
jdhoffa
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make benchmark selector data-driven and change when one of these change:
My assumption is that only these influence the possible benchmark values but I might be wrong. Actually even the sector probably doesn't but I just add it as one of the 'top-level' filters.