Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up landing page #46

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Wire up landing page #46

merged 3 commits into from
Oct 23, 2024

Conversation

MonikaFu
Copy link
Contributor

@MonikaFu MonikaFu commented Oct 23, 2024 •
edited
Loading

Closes #39

  • Wire up the selectors from landing page of the sector view
  • make the sector and asset class selectors data-driven.
  • remove 'Go' button from sector-view page (post landing) as it hinders user-experience

@MonikaFu MonikaFu requested a review from jdhoffa October 23, 2024 10:22
jdhoffa
jdhoffa approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!!

@MonikaFu MonikaFu merged commit a5c411d into main Oct 23, 2024
4 of 5 checks passed
@MonikaFu MonikaFu deleted the wire-up-landing-page branch October 23, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Decide if we want the "Go!" button for selection of sector and asset class in every case
2 participants
@MonikaFu @jdhoffa