Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company level bubble #33

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Add company level bubble #33

merged 5 commits into from
Aug 22, 2024

Conversation

MonikaFu
Copy link
Contributor

In this PR I add a css/tailwind layout for the company-level section and add the bubble chart for companies.

NOTE: the asset class and sector selector are not wired up entirely properly but I believe that is due to the way that the mechanism is different with the 'Go!' button instead of event change for each selector change. I don't think it makes a lot of sense to spend time on making it work at this moment since we're going to remove the selectors from individual plots anyway and will have to re-write mechanism for the plotting function.

@MonikaFu MonikaFu requested a review from jdhoffa August 21, 2024 13:29
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!
Thanks for getting all of the plots in place 😊

@MonikaFu MonikaFu merged commit 609823c into main Aug 22, 2024
4 of 5 checks passed
@MonikaFu MonikaFu deleted the add-company-level-bubble branch August 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants