💄 JS files lose all unused vars and imports

[jdhoffa]

This PR is where things get a little spicy. I am simply removing every var and import that is unused!
There are a few categories here:

• The simplest is just tech debt, a var or function argument was defined (and probably used at some point) and later removed from he function body, but left in the body
• vars that are defined for their side-effects (you can just remove them and call the methods alone)
• unused package imports (self explanatory)

This PR affects the following plots:

• pie_exploded
• tech_exposure
• tech_exposure_company
• techmix_sector
• timeline
• trajectory_alignment

I will post side-by-sides of these plots before and after to show they still render (and I have visually inspected them to ensure all interactivity still functions as expected)

@MonikaFu FYI

Relates to #96
Towards #29

[jdhoffa]

pie_exploded

before

after

tech_exposure

before

after

tech_exposure_company

before

after

techmix_sector

before

after

timeline

before

after

trajectory_alignment

before

after

[cjyetman]

union is being used on line 130/129 no?

[jdhoffa]

Indeed, however that union call is a native method in the Set prototype.
Check it:

Adding the following console logging to the js there:

let subgroups = Array.from(subgroups0.union(subgroups1));
console.log(subgroups0.constructor.name);
console.log(Set.prototype.union);

and inspecting in the console, I see:

[jdhoffa]

And note that if I add the line back:

import { union } from 'd3-array';

and do the same logging, it yields the same source:

We were never calling the union method from d3-array in the first place

[jdhoffa]

Seems like its new: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union

🤔

[jdhoffa]

Might be more backwards compatible to use the d3 implementation? assuming it does the same thing?

But I'm not sure how to even force it to actually do/ use that, and feels a bit out of scope for this PR

[cjyetman]

Yeah, it must be a new-ish JS function. D3 used to provide stuff like that before they were available in vanilla JS. I guess luckily the syntax/interface/behavior is sufficiently similar.

[jdhoffa]

Well we can monitor it and if things start to seem off, we will know where to look :-)

[cjyetman]

I suspect it is using a vanilla JS Set, and not an old-skool <=D3v4 set/map, but I don't really know the whole evolution of this code anymore, and it's spread out over multiple repos.

pacta-dashboard-svelte/src/js/techmix_sector.js

Line 126 in 7a24b19

let subgroups0 = new Set(d3.map(subdataTechPerYear[0].stackedData, (d) => d.key).keys());