Repository navigation
Conversation
Stopkaa
force-pushed
the
opendsme-upgrade
branch
from
October 29, 2026 16:11
4e87aca to
21b0053
Compare
crasbe
reviewed
Oct 29, 2026
Co-authored-by: crasbe <crasbe@gmail.com>
crasbe
reviewed
Oct 30, 2026
| gnrc_netif_hdr_t *hdr = (gnrc_netif_hdr_t *)pkt->data; | ||
|
|
||
| if (hdr->flags &= GNRC_NETIF_HDR_FLAGS_MULTICAST) { | ||
| if (hdr->flags & GNRC_NETIF_HDR_FLAGS_MULTICAST) { |
Contributor
There was a problem hiding this comment.
Claude suggested checking for ..._BROADCAST as well. I'll have to check if both have to be set (..._BROADCAST | ..._MULTICAST) or either one has to be set.
Will check again, but the session is on my office workstation which I won't see until next week or the week after.
Member
There was a problem hiding this comment.
BROADCAST and MULTICAST are the same in IEEE 802.15.4, but not in gnrc_netif (which also serves other link layers which make a difference there; e.g., Ethernet). So it does sound sensible to check both for a 802.15.4-based MAC.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR aims to fix #21922. First of all I don't know how openDSME has worked at all as I tried the example with 2023.07 (#18156) with no success. The issue was that
radio_offon the nrf also turns off the clock source the slot timer needs to be accurate so the node wakes up too late for the beacon and loses sync right after association. As we don't want to keep that clock running for every application the simplest solution was to request it in the auto_init of the nrf radio since it's only needed for opendsme.This enables receiving beacons again but only one frame could be sent all following frames are ignored by gnrc_netif since it waits for a
confirm_send()that opendsme never calls cause of lack a netdev see the ugly hack inDSMEPlatform::initializeTesting procedure
On master you will have the issue described in #21922
With this PR the device will stay associated and is able to transmit multiple frames
Issues/PRs references
Fixes #21922
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: