Draft: External cpu dir #21942
Draft
Draft: External cpu dir #21942
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teufelchen1
commented
Dec 8, 2025
|
|
||
| # Detect provided / used / optional features that do not exist | ||
| include $(RIOTMAKE)/features_existing.inc.mk | ||
| -include $(EXTERNAL_CPU_DIRS)/features_existing.inc.mk |
Contributor
Author
There was a problem hiding this comment.
Needs to be converted to an iterator, should this approach be chosen.
Member
|
I think this approach is quite alright, esp. considering that, while useful, this will only impact the very very few external cpus that (should ever) exist. Would be neat to have a test for this approach though just to make sure that we don't break it by accident, ty for this 👍 |
crasbe
added
Type: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a continuation of #20447.
The first commit is basically a rebase of that PR onto the current master (missing a lot var-name changes that are not relevant to the second commit).
The second commit is a first idea on how to solve the problem that cpus are features and therefore have to be in the
features_existing.inc.mk. The solution taken here is to have a secondfeatures_existing.inc.mkin the external CPU dir.Note that this PR does not necessarily replace the original one. I just need a place to test and discuss the options for this specific issue.
Testing procedure
TBD
Issues/PRs references
#20447