Skip to content

cpu/esp32: fixes for boot issues and crashes on ESP32 [backport 2023.1] #19196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Jan 25, 2023
Merged

cpu/esp32: fixes for boot issues and crashes on ESP32 [backport 2023.1] #19196

bors merged 2 commits into from
Jan 25, 2023

Conversation

@gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 25, 2023 •
edited
Loading

Backport of PR #19192

Contribution description

In syscalls_init() there is a call to malloc(), which will return NULL if the heap is not initialized before, causing the entire board to fail booting if module esp_idf_heap is used, for example if the WiFi network interface is used.

API of vTaskDelete() says, that if NULL is passed to vTaskDelete the calling task should be deleted.

This PR needs a backport to 2023.01.

Testing procedure

USEMODULE=esp_idf_heap BOARD=esp32-wroom-32 make -C tests/malloc

should work now but hangs in startup without the PR.

Issues/PRs references

Issue was introduced with PR #19146

@Flole998 @gschorcht
cpu/esp32: Make sure heap is initialized early enough
f5a9b5c 
In syscalls_init() there is a call to malloc(), which will return NULL if the heap is not initialized before, causing the entire board to fail booting if MODULE_ESP_IDF_HEAP is used.
@Flole998 @gschorcht
cpu/esp_common/freertos: Handle NULL being passed to vTaskDelete
14db253
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jan 25, 2023
@gschorcht gschorcht requested a review from benpicco January 25, 2023 13:32
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 25, 2023
@riot-ci
Copy link

riot-ci commented Jan 25, 2023

Murdock results

✔️ PASSED

14db253 cpu/esp_common/freertos: Handle NULL being passed to vTaskDelete

Success Failures Total Runtime
6770 0 6770 10m:09s

Artifacts

benpicco
benpicco approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 25, 2023

Build succeeded:

@bors bors bot merged commit 599e7fd into RIOT-OS:2023.01-branch Jan 25, 2023
@gschorcht gschorcht deleted the backport/2023.1/cpu/esp32_fix_boot_issue_wifi branch February 1, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gschorcht @riot-ci @benpicco @Flole998