Skip to content

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 19, 2022

Contribution description

Fixes synchronization issues on stdio_uart. Copied from the setup function in tests/congure_reno/tests/01-run.py.

See #15968 (comment) ff.

Testing procedure

CI: run tests should pass on both Murdocks.

Issues/PRs references

Follow-up fix on #15968

Fixes synchronization issues on stdio_uart. Copied from the setup
function in tests/congure_reno/tests/01-run.py
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 19, 2022
@miri64 miri64 requested review from aabadie and benpicco October 19, 2022 07:52
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Oct 19, 2022
@riot-ci
Copy link

riot-ci commented Oct 19, 2022

Murdock results

✔️ PASSED

8cf4844 tests/congure_abe: reset node before starting terminal

Success Failures Total Runtime
1991 0 1991 07m:25s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64 miri64 added CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 19, 2022
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the test is passing now on ci-prod!

ACK

@miri64
Copy link
Member Author

miri64 commented Oct 19, 2022

The failure of the pkg_edhoc_c test seems unrelated... restarting Murdock again, this time without running the tests

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Oct 19, 2022
@miri64 miri64 enabled auto-merge October 19, 2022 09:29
@miri64
Copy link
Member Author

miri64 commented Oct 19, 2022

Mhh... looking at it again: the test was not executed on samr21-xpro again... I pinged Kaspar about this offline. I confirmed however locally, that the test works:

$ QUIETER=1 BOARD=samr21-xpro make -C tests/congure_abe/ --no-print-directory -j flash test
Building application "tests_congure_abe" for "samr21-xpro" with MCU "samd21".

[INFO] edbg binary not found - building it from source now
CC= CFLAGS= make -C /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg
[INFO] edbg binary successfully built!
   text	   data	    bss	    dec	    hex	filename
  17772	    132	   2492	  20396	   4fac	/home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.elf
/home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg/edbg.sh flash /home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.bin
### Flashing Target ###
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800005161 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Verification...... done.
Done flashing
.......
----------------------------------------------------------------------
Ran 7 tests in 14.349s

OK

(on master I have the same failures as in Murdock)

@miri64 miri64 merged commit e0e0c40 into RIOT-OS:master Oct 19, 2022
@miri64 miri64 deleted the tests/fix/congure_abe branch October 20, 2022 05:52
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants