-
Notifications
You must be signed in to change notification settings - Fork 2.1k
tests/congure_abe: reset node before starting terminal #18769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes synchronization issues on stdio_uart. Copied from the setup function in tests/congure_reno/tests/01-run.py
Murdock results✔️ PASSED 8cf4844 tests/congure_abe: reset node before starting terminal
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the test is passing now on ci-prod!
ACK
The failure of the |
Mhh... looking at it again: the test was not executed on $ QUIETER=1 BOARD=samr21-xpro make -C tests/congure_abe/ --no-print-directory -j flash test
Building application "tests_congure_abe" for "samr21-xpro" with MCU "samd21".
[INFO] edbg binary not found - building it from source now
CC= CFLAGS= make -C /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg
[INFO] edbg binary successfully built!
text data bss dec hex filename
17772 132 2492 20396 4fac /home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.elf
/home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg/edbg.sh flash /home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.bin
### Flashing Target ###
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800005161 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Verification...... done.
Done flashing
.......
----------------------------------------------------------------------
Ran 7 tests in 14.349s
OK (on master I have the same failures as in Murdock) |
Contribution description
Fixes synchronization issues on stdio_uart. Copied from the setup function in tests/congure_reno/tests/01-run.py.
See #15968 (comment) ff.
Testing procedure
CI: run tests
should pass on both Murdocks.Issues/PRs references
Follow-up fix on #15968