Skip to content

Conversation

@zoedberg
Copy link
Member

@zoedberg zoedberg commented Mar 13, 2025

This PR updates the tests to the v0.11 fixes and improvements epic - part 2 (part 1: #30).

The part 2 of the epic includes the following fixes/changes:

  • update MSRV to 1.80.0 1.81.0 (due to aws-lc-sys half)
  • remove duplication of check_chain_net on the AnyResolver
  • lint with Rust 1.85.0
  • fix STL and unit tests that were left out in part 1
  • add a test to show bug when using WitnessOrd::Ignored + fix select valid witness when using WitnessOrd::Ignored (make sure to select mined/mempool TXs first)
  • add unsafe history checks on validation (unsafe means the witness TX might be at risk in case of a reorg, because it doesn't have enough confirmations)
  • add a method to check if allocations of an outpoint may be at risk if spent (particularly important when merging allocations during send, because a merged allocation that becomes invalid invalidates other all the other allocations as well)
  • change some validation warnings to errors + do not throw error during validation if consignment has some warnings
  • remove blank transitions (they were causing an inflation bug and making all other transitions unneeded)
  • drop supplements (feature was incomplete and unused)
  • drop extensions and valencies (no immediate use case was found and the feature was incomplete, will maybe reintroduce them in the future)
  • drop interfaces (simplify schema handling, drop incomplete/unused code and reduce testing surface)
  • drop RgbIsa timechain (was just a placheholder, will be reintroduced if a use case that needs it arises)
  • move indexers from rgb-runtime to rgb-std (so a wallet can avoid depending on rgb-runtime, which depends on bp-wallet, if it only needs to use the resolvers)
  • drop computed state (defined in RCP-240327A) placeholders (it should be possible to do in a non-consesus way)
  • possibility to have multiple tapret tweaks per terminal
  • fix derive: allow to see funds sent to the original address even if the terminal has also been tweaked for an RGB commitment
  • possibility to optionally specify an internal tapret key in the RGB invoice when specifying a WitnessVout beneficiary. This allows a sender to embed the tapret commitment on the receiver output (thus avoiding to construct a bitcoin change output just to put the commitment)
  • address some TODOs (move BlockHeight to bp-consensus, use NonEmptyVec in TypedAssigns, remove commented code, allow more errors in evolve_state, use NonEmptyOrdSet in Inputs)
  • fix validate_consignment_resolver_error test
  • add PermissionedFungibleAsset (PFA) schema
  • drop attachment assignment (feature was incomplete and unused)
  • refactor anchor and related structures (after unified seals there were some redundancy and unneeded complexity left)
  • StandardTypes: filter type system for schema, in order to make Kit types smaller
  • fix JSON (de)serialization of objects + use serde_json instead of serde_yaml (which is deprecated) in tests
  • schema: remove timestamp and developer (potentially misleading)
  • remove ReservedBytes (untested and insufficient to achieve the desired flexibility)
  • schema: add optional default assignment
  • invoice: change amount and assignment name display and parsing
  • add seal closing strategy to genesis (more future-proof)
  • add Inflatable Fungible Asset (IFA) schema

This is not yet complete, we'll add more commits in the following days and update the description accordingly.

Involved PRs:

@zoedberg zoedberg self-assigned this Mar 13, 2025
@zoedberg zoedberg force-pushed the 0.11.1-2 branch 2 times, most recently from 0cee011 to 7f6e0d8 Compare March 13, 2025 17:39
@zoedberg zoedberg force-pushed the 0.11.1-2 branch 4 times, most recently from cf665cb to a1b8e57 Compare March 14, 2025 09:17
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.09%. Comparing base (d3690d1) to head (bfc31ed).

Additional details and impacted files
@@               Coverage Diff               @@
##           v0.11_fixes      #35      +/-   ##
===============================================
+ Coverage        37.10%   41.09%   +3.98%     
===============================================
  Files              276      255      -21     
  Lines            41375    37798    -3577     
===============================================
+ Hits             15354    15532     +178     
+ Misses           26021    22266    -3755     
Flag Coverage Δ
rust 41.09% <ø> (+3.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zoedberg zoedberg force-pushed the 0.11.1-2 branch 2 times, most recently from b328baf to 5a756dc Compare April 22, 2025 14:59
@zoedberg zoedberg force-pushed the 0.11.1-2 branch 2 times, most recently from 65212ba to e177198 Compare April 23, 2025 18:30
@zoedberg zoedberg mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants