Skip to content

Conversation

dr-orlovsky
Copy link
Member

This PR summarizes 4 moth of Bitfinex team work on simplifying v0.11 branch, including changes coming from dependencies PR:

multiple witnesses are required for RBFs and lightning
@dr-orlovsky dr-orlovsky mentioned this pull request May 11, 2025
Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 16.78445% with 1884 lines in your changes missing coverage. Please review.

Project coverage is 26.8%. Comparing base (670a7b6) to head (cce223e).
Report is 297 commits behind head on master.

Files with missing lines Patch % Lines
src/contract/builder.rs 0.0% 510 Missing ⚠️
src/contract/data.rs 0.0% 329 Missing ⚠️
src/persistence/stock.rs 4.8% 297 Missing ⚠️
src/persistence/memory.rs 3.0% 128 Missing ⚠️
src/indexers/electrum_blocking.rs 0.0% 80 Missing ⚠️
src/stl/specs.rs 23.1% 70 Missing ⚠️
src/containers/consignment.rs 0.0% 54 Missing ⚠️
src/indexers/any.rs 0.0% 52 Missing ⚠️
src/containers/anchors.rs 0.0% 49 Missing ⚠️
src/contract/merge_reveal.rs 0.0% 43 Missing ⚠️
... and 21 more

❌ Your patch check has failed because the patch coverage (16.8%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #311     +/-   ##
========================================
+ Coverage    19.5%   26.8%   +7.3%     
========================================
  Files          40      37      -3     
  Lines        8453    5710   -2743     
========================================
- Hits         1652    1531    -121     
+ Misses       6801    4179   -2622     
Flag Coverage Δ
rust 26.8% <16.8%> (+7.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants