Skip to content

Neoag use case#3

Merged
Patricia-A-Apellaniz merged 12 commits into
mainfrom
neoag-use-case
Jun 9, 2026
Merged

Neoag use case#3
Patricia-A-Apellaniz merged 12 commits into
mainfrom
neoag-use-case

Conversation

@Patricia-A-Apellaniz

Copy link
Copy Markdown
Collaborator

No description provided.

@quimaguirre

quimaguirre commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

The update is great! The app works wonderful in general. Still, I have found some bugs that I detail here:

  • The text in the navigation menu buttons is larger than the buttons when I run the app in Chrome through my laptop screen.
  • When introducing letters to Age, the application breaks. It should prevent somehow from breaking (show a message, like when a number > 120 is introduced).
  • The application does not let me introduce a new use case. I tried with a RAI v2 containing the real dataset, but it was impossible.
  • The application breaks when deleting an entry from the RAI example dataset. I think the IDs given by the app do not correspond with the IDs from the table. This is the error message:
Traceback (most recent call last):
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/shiny/reactive/_reactives.py", line 1083, in _run
    await self._fn()
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/shiny/_utils.py", line 277, in fn_async
    return fn(*args, **kwargs)
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/shiny/reactive/_reactives.py", line 1414, in new_user_fn
    return user_fn()
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/XAInyPredictor/shinyapp/data_input.py", line 517, in _delete_patient
    updated_df = current_df.drop(index=list(selected_rows)).reset_index(drop=True)
                 ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/pandas/core/frame.py", line 6288, in drop
    return super().drop(
           ~~~~~~~~~~~~^
        labels=labels,
        ^^^^^^^^^^^^^^
    ...<5 lines>...
        errors=errors,
        ^^^^^^^^^^^^^^
    )
    ^
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/pandas/core/generic.py", line 4644, in drop
    obj = obj._drop_axis(labels, axis, level=level, errors=errors)
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/pandas/core/generic.py", line 4686, in _drop_axis
    new_axis = axis.drop(labels, errors=errors)
  File "/home/coder/staliclavenv/lib/python3.14/site-packages/pandas/core/indexes/base.py", line 7268, in drop
    raise KeyError(f"{labels[mask].tolist()} not found in axis")
KeyError: '[1] not found in axis'

@MarElizo

MarElizo commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

First of all, thank you for the recent updates! It looks amazing! In addition to the issues already reported, I have identified a few bugs and suggestions that I detail below:

  • As previously mentioned, the application breaks when letters are introduced in the Age field. However, I have noticed that the same issue occurs in other numerical input fields (e.g., BMI). I would suggest applying the same suggested solution to the Age field.
  • When adding multiple patients, if one of them triggers the Input validation failed error, all previously inserted patients are deleted. Would it be possible to preserve the valid entries that had already been added before the error occurred?
  • Also after triggering the Input validation failed error it is not possible to enter manually a new patient unless the page is refreshed or new are added in other way.
  • As a purely visual suggestion, the Confirmation required message is displayed in yellow and with a specific style. It might make it more intuitive for clinicians if the Confirm cohort button (and external blue box) followed the same color and style.
  • There seem to be some issues with the Feature Context Curves. The displayed points do not appear to lie on the corresponding curves.

@quimaguirre quimaguirre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bugs have been fixed successfully.

@Patricia-A-Apellaniz Patricia-A-Apellaniz merged commit 3021f13 into main Jun 9, 2026
3 checks passed
@quimaguirre quimaguirre deleted the neoag-use-case branch June 16, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants