Skip to content

Bug fixes with on-disk result storage#25

Merged
ben-nowacki merged 6 commits intoREIL-UConn:mainfrom
ben-nowacki:main
Mar 20, 2026
Merged

Bug fixes with on-disk result storage#25
ben-nowacki merged 6 commits intoREIL-UConn:mainfrom
ben-nowacki:main

Conversation

@ben-nowacki
Copy link
Copy Markdown
Collaborator

@ben-nowacki ben-nowacki commented Mar 20, 2026

Description

Fixes with on-disk result storage

  • On-disk storage failed to save callback results. Evaluation callback results were overwritten for multi-epoch training phases.
  • Created new CallbackStore to follow ArtifactStore, MetricStore, and ExecutionStore pattern
  • On-disk pickle files now use global, monotonically increasing file names to prevent naming collisions
  • Experiment serialization updated to support this logic

Fixed no-length progress tasks not refreshing

  • New manual-refresh approach to ProgressManager failed to refresh no-length ProgressStyles (e.g., ProgressSpinner)
  • Added new auto-refresh task with ProgressStyle instances allowed to opt-in to this refresh thread

Related Issues

N/A

How Has This Been Tested?

  • Local pytest run
  • CI passes
  • Manual checks (describe if needed)

Checklist

  • My code follows project style guidelines: nox -s pre-commit
  • I have added tests that prove my fix is effective or my feature works: nox -s unit
  • I have updated documentation if needed: nox -s docs
  • I have linked related issues

@ben-nowacki ben-nowacki marked this pull request as ready for review March 20, 2026 21:49
@ben-nowacki ben-nowacki merged commit 8aaf009 into REIL-UConn:main Mar 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants