add abseil to recipes #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds abseil-cpp to recipes. abseil-cpp is used by package s2, which in turn is imported by package
sf, which has about 1000 revdeps. The newly submitted s2 now uses abseil from the system, where it is present; on the all other CRAN build machines (debian, fedora, windows) this is present. Theabslfile (written by Brian) sets up abseil for recipes. I could run most of the cook GA (see here) - it breaks somewhere after 2.5 hours but passes through its abseil job. I added two further CMAKE 3.5 directives needed to pass other targets, but don't know how to fix where it breaks now (something with ninja?).It would be great if this could be added relatively quickly, we have a deadline on May 25.
Cc: @paleolimbot