feat(router): [breaking] change head merge order #7970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7961fe9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wmertens
force-pushed
the
v2-head-changes
branch
from
d99826c to
4a80aad
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Varixo
approved these changes
Sep 18, 2025
reverses head merging for plain objects but retains order for functions
wmertens
force-pushed
the
v2-head-changes
branch
from
4a80aad to
7961fe9
Compare
shairez
reviewed
Sep 23, 2025
| '@qwik.dev/router': major | ||
| --- | ||
|
|
||
| Breaking: The order of head export merging has been slightly. Plain objects now override outer ones. Functions still are run inner-first. |
There was a problem hiding this comment.
maybe add 💥 in front of the BREAKING
shairez
reviewed
Sep 23, 2025
|
|
||
| So first all plain object `head` exports are merged, and then the function `head` exports are called in reverse order. | ||
|
|
||
| Furthermore, if two values in arrays (like `meta` or `links`) have the same `key`, the last one wins. This allows you to override specific meta tags. |
There was a problem hiding this comment.
this is related to objects not functions right?
if so I think it should come before the paragraph about functions, to make sure people won't think it's related to functions.
There was a problem hiding this comment.
It applies to both. Let me think about how to word it better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of merging head objects is surprising, like #7868.
This PR changes it to merge objects in the unsurprising order, but keep merging functions in the original order.