-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Patch 2 #7616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Patch 2 #7616
Conversation
Configure tsconfig.json for css modules plugin
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great but not everyone uses CSS modules.
Can you change your PR to be comments instead?
I fully understand, but when i create a project using cli, i get it with css modules by default. |
Yes, css modules work, as well as regular modules, inline modules etc. Not everyone uses them. How about putting comments like |
Thanks, good point. Probably even better add this only in boilerplate where css modules are actually used. But I am a bit confused about the repository where it lives |
so actually, "base" is shared between all templates, and "empty" is a new qwik app starter. "playground" is more bells and whistles. That said, if you can add some comments I think it will be ok in base. |
What is it?
Description
Satisfaction for developers.
Allow auto compleation in typescript files for css modules class names.
Checklist
pnpm change