Skip to content

Patch 2 #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Patch 2 #7616

wants to merge 4 commits into from

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented May 19, 2025

What is it?

  • Feature / enhancement

Description

Satisfaction for developers.
Allow auto compleation in typescript files for css modules class names.

image

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@FDiskas FDiskas requested a review from a team as a code owner May 19, 2025 23:06
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: c00d56e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7616
npm i https://pkg.pr.new/@builder.io/qwik-city@7616
npm i https://pkg.pr.new/eslint-plugin-qwik@7616
npm i https://pkg.pr.new/create-qwik@7616

commit: c00d56e

Copy link
Contributor

github-actions bot commented May 19, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c00d56e

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great but not everyone uses CSS modules.

Can you change your PR to be comments instead?

@FDiskas
Copy link
Contributor Author

FDiskas commented May 20, 2025

This looks great but not everyone uses CSS modules.

Can you change your PR to be comments instead?

I fully understand, but when i create a project using cli, i get it with css modules by default.

@wmertens
Copy link
Member

Yes, css modules work, as well as regular modules, inline modules etc. Not everyone uses them.

How about putting comments like // if you do not use CSS modules, remove this line and delete the module from package.json?

@FDiskas
Copy link
Contributor Author

FDiskas commented May 20, 2025

Thanks, good point. Probably even better add this only in boilerplate where css modules are actually used. But I am a bit confused about the repository where it lives

@wmertens
Copy link
Member

so actually, "base" is shared between all templates, and "empty" is a new qwik app starter. "playground" is more bells and whistles.

That said, if you can add some comments I think it will be ok in base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants