Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input's value is string when passing number on V1 #7249

Merged
merged 11 commits into from
Jan 20, 2025

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jan 13, 2025

What is it?

related to #7182.
Qwik Development (view)

The purpose of this is that the value of the input is a string when the input triggers the onChange event, even though the type is number

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 9f14b53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 marked this pull request as ready for review January 14, 2025 06:10
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner January 14, 2025 06:10
@maiieul maiieul changed the title fix: a bug related to 7182, migrate the code fix: input's value is string when passing number on V1 Jan 14, 2025
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner January 20, 2025 01:21
Copy link

pkg-pr-new bot commented Jan 20, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7249
npm i https://pkg.pr.new/@builder.io/qwik-city@7249
npm i https://pkg.pr.new/eslint-plugin-qwik@7249
npm i https://pkg.pr.new/create-qwik@7249

commit: aa51c37

Copy link
Contributor

github-actions bot commented Jan 20, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview aa51c37

@shairez shairez merged commit af8fd6d into QwikDev:main Jan 20, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants