Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert destructured string prop to props variable #7191

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Dec 24, 2024

No description provided.

@Varixo Varixo self-assigned this Dec 24, 2024
@Varixo Varixo requested a review from a team as a code owner December 24, 2024 13:35
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 1413bc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo force-pushed the v2-destructuring-colon-prop branch from 8711d73 to 1413bc0 Compare December 24, 2024 13:37
@Varixo Varixo requested a review from wmertens December 24, 2024 13:39
Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7191
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7191
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7191
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7191

commit: 1413bc0

@Varixo Varixo linked an issue Dec 24, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1413bc0

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🚀 🎆

@wmertens wmertens merged commit 7160354 into build/v2 Dec 25, 2024
22 checks passed
@wmertens wmertens deleted the v2-destructuring-colon-prop branch December 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐞] v2 - the optimizer does not change props to a single variable
2 participants