Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a bug that error in the middleware occurs 404 #6951

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Oct 9, 2024

#6950

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners October 9, 2024 09:06
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 6a17e2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 6a17e2c

.changeset/gorgeous-garlics-melt.md Outdated Show resolved Hide resolved
@JerryWu1234
Copy link
Contributor Author

@shairez @wmertens

I have added a test for this PR.

@shairez shairez dismissed wmertens’s stale review January 9, 2025 12:12

seems like changes were made

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Jerry!

@shairez shairez merged commit 6e3bb16 into QwikDev:main Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants