-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix: Include macOS Seatbelt Sandbox Files in NPM Package #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📋 Review SummaryThis PR addresses a critical issue where macOS sandbox profile files ( 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo specific issues identified in this review. 🟡 HighNo specific issues identified in this review. 🟢 MediumNo specific issues identified in this review. 🔵 LowNo specific issues identified in this review. ✅ Highlights
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
The NPM package distribution was missing critical macOS sandbox profile files (
*.sb), which are required for the sandboxing functionality on macOS systems. When users installedqwen-codefrom NPM, these six seatbelt files were not included in the package:sandbox-macos-permissive-closed.sbsandbox-macos-permissive-open.sbsandbox-macos-permissive-proxied.sbsandbox-macos-restrictive-closed.sbsandbox-macos-restrictive-open.sbsandbox-macos-restrictive-proxied.sbThis caused the tool execution sandbox feature to fail on macOS when users tried to run the CLI with sandbox restrictions enabled.
Root Cause
The
scripts/prepare-package.jsscript, which generates thepackage.jsonfor the published NPM package, was only including specific files in itsfilesarray:While the build process correctly copied the
.sbfiles to thedist/directory, they were excluded from the published package due to the missing glob pattern.Solution
Updated the
filesarray inscripts/prepare-package.jsto include the glob pattern'*.sb':This ensures all macOS Seatbelt sandbox profile files are included when the package is published to NPM.
Impact
.sbtext files)Linked issues / bugs