-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom fonts #96
Conversation
@rgodha24 is attempting to deploy a commit to the Tom Labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm not quite sure to understand what "Installed fonts" mean, you could provide more details?
We'll need some virtualized list too, opening the font dropdown is currently freezing the tab for ~500ms on a high-end MacBook:
We should also consider lazy-loading the fonts files themselves, instead of triggering +1500 requests to jsdelivr when opening the dropdown.
Typecheck, eslint and some tests are failing, could you take a look at those?
output.mp4this seems better lol |
I kinda hate being that guy, but the CI is working on my machine. I have no clue why its failing on GH actions. I even did a fresh install of my node_modules with the pnpm store cleaned. |
Had the same issue on my two PRs this morning, so it's not you. It was working fine 3 months ago so not sure what's going on yet, will take a look. |
Fixed the issues in #100, you can rebase |
git is hard but I think it should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added custom fonts support
it supports any latin fonts from fontsource.
because radix-themes doesn't have a combobox, it's just in a giant <Select>. You can just type in the name of the font from fontsource and it searches through the select for you.
we could change it to use this ariakit example, but that's another dep and I wasn't sure if you'd be fine with that.