Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiple selection #52

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: multiple selection #52

wants to merge 11 commits into from

Conversation

vshakitskiy
Copy link
Contributor

@vshakitskiy vshakitskiy commented Jan 7, 2024 •
edited
Loading

Still need to remake border, background and shadow section, so I'll add them in the next commits.
And there are also some type mistakes that we need to fix.

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2024

@vshakitskiy is attempting to deploy a commit to the Tom Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vshakitskiy vshakitskiy marked this pull request as draft January 7, 2024 20:30
@vshakitskiy vshakitskiy marked this pull request as ready for review January 12, 2024 15:54
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ogstudio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 5:01pm

QuiiBz
QuiiBz requested changes Jan 13, 2024
View reviewed changes
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited for this, thanks! Some early feedback:

When selecting a single element, it no longer shows the Background / Border / Shadow sections:

Screenshot 2024-01-13 at 11 12 38

apps/dashboard/src/components/RightPanel/SizePositionSection.tsx Outdated
Comment on lines 22 to 23
selectedElements.forEach((selectedElement) => {
updateElement({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try to have a single state update for all selected elements at once? That would also make a better ctrl+z/Z experience

@vshakitskiy
Copy link
Contributor Author

Super excited for this, thanks! Some early feedback:

When selecting a single element, it no longer shows the Background / Border / Shadow sections:

Screenshot 2024-01-13 at 11 12 38

Everything is working fine now:

изображение

@vshakitskiy vshakitskiy requested a review from QuiiBz January 15, 2024 15:37
@vshakitskiy vshakitskiy mentioned this pull request Jan 16, 2024
Closed
@QuiiBz
Copy link
Owner

QuiiBz commented Jan 16, 2024

Will take a look later day if I have enough time.

@QuiiBz
Copy link
Owner

QuiiBz commented Jan 19, 2024

This is so good, thank you! I'll make some improvements this weekend:

  • The right panel should only show the relevant sections when selecting multiple elements. In this example, we shouldn't show the "Font" section since I'm selecting a text element and a box element:
Screenshot 2024-01-19 at 18 05 45
  • I'll also add a way to move all selected elements at the same time, which doesn't seem to be supported right now

@vshakitskiy
Copy link
Contributor Author

I'll also add a way to move all selected elements at the same time, which doesn't seem to be supported right now

Yea, I think we can make resizing and rotating working at the same time as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiiBz QuiiBz Awaiting requested review from QuiiBz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshakitskiy @QuiiBz