Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: elements naming #24

Closed
wants to merge 0 commits into from
Closed

feat: elements naming #24

wants to merge 0 commits into from

Conversation

vshakitskiy
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023

@vshakitskiy is attempting to deploy a commit to the Tom Team on Vercel.

A member of the Team first needs to authorize it.

@vshakitskiy
Copy link
Contributor Author

I think we also need to add element name input on the right panel.

@vshakitskiy vshakitskiy marked this pull request as draft December 29, 2023 12:26
@vshakitskiy vshakitskiy marked this pull request as ready for review December 29, 2023 12:41
@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ogstudio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 8:24am

QuiiBz
QuiiBz requested changes Dec 30, 2023
View reviewed changes
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's gonna be useful! Some comments:

apps/dashboard/src/components/RightPanel/NameSection.tsx Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this new section, it feels a bit redundant.

Screenshot 2023-12-30 at 14 22 05

What do you think of removing it, and only keep the double-click on the left panel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep only on left panel then.

apps/dashboard/src/components/LeftPanel/ElementRow.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/components/LeftPanel/ElementRow.tsx Outdated Show resolved Hide resolved
@vshakitskiy vshakitskiy requested a review from QuiiBz December 30, 2023 14:31
@QuiiBz
Copy link
Owner

QuiiBz commented Dec 31, 2023

Could you rebase the branch? I made some changes in #27 around the file structure. Then we'll be ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiiBz QuiiBz Awaiting requested review from QuiiBz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elements names instead of element types
2 participants
@vshakitskiy @QuiiBz