feat: add exhaustive currency whitelist validations (#524)#777
Merged
Baskarayelu merged 2 commits intoQuickLendX:mainfrom Apr 1, 2026
Merged
Conversation
Implements full whitelist validation paths for add/remove/set/clear flows with explicit admin.require_auth() on all write operations, saturating arithmetic overflow protection in pagination, comprehensive NatSpec-style doc comments, and exhaustive boundary tests covering empty-list, offset/limit saturation, overflow, ordering, modification, security, and large-dataset edge cases. Closes QuickLendX#524
|
@dannyy2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin.require_auth()toadd_currencyandset_currencies(previously relied on an implicit comment instead of enforced runtime auth)get_whitelisted_currencies_paged:(offset + limit)→offset.saturating_add(limit)to handleu32::MAXinputs safelyCurrencyWhitelistfunctions (parameters, errors, boundary tables, security notes)test_currency.rswith 12 exhaustive boundary test functions covering empty-list, offset/limit saturation, overflow protection, ordering consistency, post-modification pagination, security access, large datasets, concurrent modification simulation, address deduplication, and storage efficiencydocs/contracts/currency-whitelist.mdwith authentication model table, security hardening notes, and a full test coverage matrixTest plan
src/test_currency.rscompiles with zero errorscurrency.rslogicCloses #524