Feature/vesting admin threat model#766
Merged
Baskarayelu merged 4 commits intoQuickLendX:mainfrom Apr 1, 2026
Merged
Conversation
- Add get_vesting_vested to public contract API (was missing from lib.rs) - Fix release() to return InvalidTimestamp before cliff instead of Ok(0) - Fix test_immediate_cliff_equals_end to use a valid schedule (cliff < end) - Add 8 admin boundary tests covering: zero amount, backdated start, end<=start, cliff>=end, role transfer, non-beneficiary release, pre-cliff error, and nonexistent schedule queries - Expand docs/contracts/vesting.md with full admin threat model table - Expand docs/contracts/settlement.md with vesting admin threat model
|
@firstJOASH Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
std is unavailable in wasm32 no_std builds. Replace std::vec::Vec with a fixed-size stack buffer and std::str::from_utf8 with core::str::from_utf8 in normalize_tag to fix the WASM CI build.
The vesting admin boundary tests and get_vesting_vested API addition grew the optimised WASM from 217668 B to 241218 B, still within the 256 KiB hard limit. Update all three baseline locations: - tests/wasm_build_size_budget.rs - scripts/check-wasm-size.sh - scripts/wasm-size-baseline.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #727 Vesting admin abuse review and optional beneficiary safeguards