Feature/best vs ranked bid tests#761
Merged
Baskarayelu merged 3 commits intoQuickLendX:mainfrom Apr 1, 2026
Merged
Conversation
|
@Samaro1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures best-bid selection always matches the first element of the ranked bid list, including all tie scenarios.
What changed:
Refactored bid selection logic to use a shared deterministic path for both best-bid and ranking flows.
Added comprehensive tie-case regression tests for:
equal profit with expected-return tie-break
equal profit/expected-return with bid-amount tie-break
equal economics with timestamp tie-break
full ties with bid_id final tie-break
insertion-order variance checks
Updated bid-ranking docs to reflect exact tie-break behavior and the best-vs-ranked invariant.
Security notes:
Centralized comparison path reduces drift risk between ranking and best-bid logic.
Deterministic ordering under full ties prevents inconsistent outcomes across validators.
Testing:
Attempted: cargo test test_bid_ranking -- --nocapture
Current status: blocked by unrelated pre-existing compile issues in the repository (src/lib.rs and src/invoice.rs).
Closes #709