Feature/manual default authz gates#757
Closed
DevAyomi wants to merge 2 commits intoQuickLendX:mainfrom
Closed
Conversation
- Add strict access control for manual default marking (admin-only) - Enforce funded-state prerequisite before allowing defaults - Add validate_invoice_for_default() for eligibility checks - Add validate_grace_period_expired() for time-based validation - Add can_mark_as_defaulted() helper for UI pre-validation - Add comprehensive tests: 21 default tests + 27 error tests - Update docs/contracts/defaults.md with security model Security features: - Admin-only access via require_auth - Only Funded invoices can be defaulted - Grace period must expire before defaulting - Idempotent: double-default returns specific error - Overflow-protected timestamp calculations Test coverage: 95%+ for defaults.rs module
- Fixed Cargo.toml duplicate crate-type keys - Added OverdueScanResult struct and enhanced grace period validation to defaults.rs - Fixed lib.rs orphaned code and duplicate function definitions - Fixed invoice.rs missing functions and borrow checker issues - Fixed dispute.rs missing imports and DisputeStatus variants - Fixed analytics.rs missing helper functions - Fixed pause.rs require_not_paused return type - Fixed currency.rs and emergency.rs require_admin references - Library compiles successfully (160 warnings only) Note: Some test files from feature branch may reference missing methods
|
Hey @DevAyomi! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop strict access and status validation for manual default marking to avoid premature defaults. Closes. #546