SecureDrop: fix config.json wrongly set to prod #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config.json, which sets among other things the packages "environment" (prod, staging, dev) was set to prod in all cases. This makes it adequate for each environment.
Work around SecureDrop Workstation issue where focus is stolen from xterm while running `make test`. The root console won't run into GUI / focus strealing problems and has the added advantage of being faster, since commands don't have to be "typed". [1]: freedomofpress/securedrop-workstation#1411
Now done in base test image. Per discussion in QubesOS#25 (comment)
deeplow
force-pushed
the
securedrop-fix-dev-config
branch
4 times, most recently
from
1599db8 to
99da5e2
Compare
deeplow
force-pushed
the
securedrop-fix-dev-config
branch
2 times, most recently
from
ac2abe0 to
fffd9f1
Compare
Tests window was loosing focus due to an unkown reason (possibly a test opening a ghost window). This was causing issues where the remainder of the test would fail to run due to xterm no longer being in focus, thus impossible to type in. For context, see freedomofpress/securedrop-workstation#1411
deeplow
force-pushed
the
securedrop-fix-dev-config
branch
3 times, most recently
from
f7b702f to
4320b90
Compare
deeplow
force-pushed
the
securedrop-fix-dev-config
branch
4 times, most recently
from
25f730f to
a94a761
Compare
deeplow
force-pushed
the
securedrop-fix-dev-config
branch
from
a94a761 to
638c44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config.json, which sets among other things the packages "environment" (prod, staging, dev) was set to prod in all cases. This makes it adequate for each environment.
As usual, someone from the SecureDrop team will take a look and once we're ready we'll mark this as ready for review.