Skip to content

Conversation

@qzhodl
Copy link
Contributor

@qzhodl qzhodl commented Oct 31, 2025

No description provided.

@qzhodl qzhodl marked this pull request as ready for review November 14, 2025 03:32
@@ -1,7 +1,10 @@
{
"admin": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this file to indicate which network it's for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are fine to me unless it is more clear for opup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c65227b

L2/deployment.md Outdated
- l1ProxyAdminOwner (Gnosis Safe): Upgrade L1 contract implementations and own L1 contract roles (e.g., systemConfigOwner)..
- l2ProxyAdminOwner (Hardware wallet): Upgrade L2 contract implementations; own L2 contracts (e.g., SoulGasToken), and vault recipients (baseFeeVaultRecipient, l1FeeVaultRecipient, sequencerFeeVaultRecipient).

Testnet admint wallets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admint -> admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 68087b4

L2/deployment.md Outdated
- l1ProxyAdminOwner (Gnosis Safe): 0x91eDD257B4184aC152cce1bbEC29FD93979Ae0db
- l2ProxyAdminOwner (Hardware Wallet): 0x187712a3e229498E9E42888761Ab9B92bceB46c7

Mainnet admint wallets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admint -> admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 68087b4

L2/deployment.md Outdated
## 15. Roll Bridge
Need to determine the ERC20 token listed on the UI

## 16. op-monitor + grafana / FDG watcher / FDF test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FDF -> FDG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 68087b4

L2/deployment.md Outdated
- L1BlobBaseFeeScalar: 114098

## 10. Set eip1559Denominator/eip1559Elasticity
- eip1559Denominator: 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there're some inconsistencies here. In the initial genesis, EIP1559DenominatorCanyon will be effective since canyonTime is 0(src), according to the code here. In opup, EIP1559DenominatorCanyon is set to 250.(src)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this code, we are setting EIP1559Denominator instead of EIP1559DenominatorCanyon in the contract.

But according to your comment, it seems that we should set EIP1559DenominatorCanyon since it replaced EIP1559Denominator since canyonTime, do I understand right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or we can set both EIP1559Denominator and EIP1559DenominatorCanyon to the same value in opup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c65227b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants