Skip to content

Replace deprecated bit32 library with Lua BitOp #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maaggs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated bit32 library with Lua BitOp #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dissector/baichuan.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
-- You should have received a copy of the GNU General Public License along with
-- this program. If not, see <https://www.gnu.org/licenses/>.

local bit32 = bit -- replace deprecated bit32 library with Wireshark's Lua BitOp library
local bc_protocol = Proto("Baichuan", "Baichuan/Reolink IP Camera Protocol")

local magic_bytes = ProtoField.int32("baichuan.magic", "magic", base.DEC)
Expand Down Expand Up @@ -453,7 +454,7 @@ local function udp_decrypt(data, tid)
for b=0, 3 do
local byte_index = x * 4 + b
local val = data:get_index(byte_index)
local key_byte = bit32.extract(xor_key_word, b*8, 8)
local key_byte = bit32.band(bit32.rshift(xor_key_word, b*8), 0xff)
val = bit32.bxor(key_byte, val)
result:set_index(byte_index, val)
if byte_index >= data:len() - 1 then
Expand Down